Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode

From: Risto Suominen
Date: Thu Feb 12 2009 - 16:12:39 EST


2009/2/12 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
>> ---
>> The testing is done on kernel version 2.6.18.
>
> That's a truly ancient kernel. Is the patch needed on current kernels?
> Does it work correctly in current kernels?
>
It does not on 2.6.24. The patch works.

> How does the cursor get re-enabled?
>
I have not thought of that.

> Should we be calling ops->cursor() if fbcon_is_inactive() is true?
>
Maybe we shouldn't, but we must. The situation is that we are ordered
to enter graphics mode and the variable saying 'graphics' is already
set in vt_ioctl.c. fbcon_is_inactive() tests it and returns true.

The question is, whether this function is called later during normal
operation, and how often?

Risto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/