Re: [PATCH] Export symbol ksize()

[Matt Mackall]

On Fri, 2009-02-13 at 07:09 +0800, Herbert Xu wrote:
> On Fri, Feb 13, 2009 at 12:10:45AM +1100, Nick Piggin wrote:
> > 
> > I would be interested to know how that goes. You always have this
> > circular issue that if a little more space helps significantly, then
> > maybe it is a good idea to explicitly ask for those bytes. Of course
> > that larger allocation is also likely to have some slack bytes.
> 
> Well, the thing is we don't know apriori whether we need the
> extra space.  The idea is to use the extra space if available
> to avoid reallocation when we hit things like IPsec.

I'm not entirely convinced by this argument. If you're concerned about
space rather than performance, then you want an allocator that doesn't
waste space in the first place and you don't try to do "sub-allocations"
by hand. If you're concerned about performance, you instead optimize
your allocator to be as fast as possible and again avoid conditional
branches for sub-allocations.

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/