Re: [RFC 0/6] x86 tip asm ENTRY,ENDPROC cleanup

From: H. Peter Anvin
Date: Fri Feb 13 2009 - 19:34:28 EST


Alexander van Heukelum wrote:

Hi Cyrill,

I like this direction. If I understand correctly:

ENTRY/END or GLOBAL/END for data.
ENTRY/ENDPROC or GLOBAL/ENDPROC for functions.


Fine for functions, but it's really not okay to use the same macros for data. Furthermore, we need to consider special entry points that don't behave like normal functions -- like system call or interrupt entry.

Why? Because if we're compiling with frame pointers, we would like the wrapper macros for functions to handle setting up and tearing down the frame pointer, at least in the common case.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/