Re: [PATCH] drivers/isdn/hardware/mISDN: change type of hfc_jiffiesto ulong

From: Jiri Slaby
Date: Sat Feb 14 2009 - 17:49:22 EST


Hannes Eder wrote:
> Patch suggested by Jiri Slaby.

Well, at least some log needed.

jiffies are ulong, make sure we fit in jiffies store variable on archs with
bits per long > 32.

> Signed-off-by: Hannes Eder <hannes@xxxxxxxxxxxxxx>
> ---
>
> This patch is based on:
> drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static
>
> drivers/isdn/hardware/mISDN/hfcpci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c
> index 2bb85c4..c7a855c 100644
> --- a/drivers/isdn/hardware/mISDN/hfcpci.c
> +++ b/drivers/isdn/hardware/mISDN/hfcpci.c
> @@ -57,7 +57,7 @@ static int HFC_cnt;
> static uint debug;
> static uint poll, tics;
> static struct timer_list hfc_tl;
> -static u32 hfc_jiffies;
> +static ulong hfc_jiffies;

Ok, unsigned long would be nicer. I though it would be implicit when writing
about ulong, but I see not in this uint-et-al context...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/