Re: [PATCH 1/1] net: forcedeth:f55c21fd9a92a444e55ad1ca4e4732d56661bf2e caused wake-on-lan regression

From: David Miller
Date: Mon Feb 16 2009 - 03:14:08 EST


From: Tobias Diedrich <ranma+kernel@xxxxxxxxxxxx>
Date: Sat, 14 Feb 2009 16:12:00 +0100

> commit f55c21fd9a92a444e55ad1ca4e4732d56661bf2e, which was
> introduced to fix the regression tracked at
> http://bugzilla.kernel.org/show_bug.cgi?id=11358
> causes the wake-on-lan mac to be reversed in the shutdown path.
> Apparently the forcedeth situation is rather messy in that the mac
> we need to writeback for a subsequent modprobe to work is exactly
> the reverse of what is needed for proper wake-on-lan.
>
> The following patch explains the situation in the comments and
> makes the call to nv_restore_mac_addr() conditional (only called if
> we are not really going for poweroff).
...
> Signed-off-by: Tobias Diedrich <ranma+kernel@xxxxxxxxxxxx>
> Tested-by: Philipp Matthias Hahn <pmhahn@xxxxxxxxxxxxx>

Applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/