Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error()

From: Sergei Shtylyov
Date: Mon Feb 16 2009 - 07:13:27 EST


Hello, I wrote:

* Add IDE_TFLAG_IN_FEATURE taskfile flag for reading Feature
register and handle it in ->tf_read.

Doesn't seem like a good name -- you can't read the features register. I should've commented to this patch earlier, of course...

Moreover, the error register shoudn't be affeceted by the HOB bit, so this flag doesn't make sense.

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/