Re: [patch 0/8] kzfree()

From: Andrew Morton
Date: Mon Feb 16 2009 - 14:59:53 EST


On Mon, 16 Feb 2009 15:29:26 +0100 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:

> This series introduces kzfree() and converts callsites which do
> memset() + kfree() explicitely.

I dunno, this looks like putting lipstick on a pig.

What is the point in zeroing memory just before freeing it? afacit
this is always done as a poor-man's poisoning operation.

But the slab allocators _already_ do poisoning, and they do it better.
And they do it configurably, whereas those sites you've been looking at
are permanently slowing the kernel down.

So I would cheerily merge and push patches titled "remove pointless
memset before kfree".

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/