Re: [PATCH] spi-gpio: Implement spidelay() for busses that need it.

From: David Brownell
Date: Mon Feb 16 2009 - 15:42:40 EST


[
NOTE: removed openwrt from the cc list, it rejects posts
from non-subscribers. Please don't cc such lists.
]

On Sunday 15 February 2009, Michael Buesch wrote:
> + * NOTE:  to clock "as fast as we can", set spi_device.max_speed_hz
> + * and spi_transfer.speed_hz to 0.

Won't work; if spi->max_speed_hz is zero, spi_async() and
friends will refuse to queue any messages.

I'm not averse to a solution that lets some boards use a
slowed-down bitbang loop. But it would be a lot easier
if you kept the default the way it is, and just added
that slowdown as an option for the existing customization
case (currently oriented towards speedup, not slowdown).

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/