Re: RT scheduling and a way to make a process hang, unkillable

From: Corey Hickey
Date: Tue Feb 17 2009 - 19:09:33 EST


Peter Zijlstra wrote:
> On Tue, 2009-02-17 at 15:45 +0530, Dhaval Giani wrote:
>
>> sched: Don't allow setuid to succeed if the user does not have rt bandwidth
>>
>> Corey Hickey reported that on using setuid to change the uid of a
>> rt process, the process would be unkillable and not be running.
>> This is because there was no rt runtime for that user group. Add
>> in a check to see if a user can attach an rt task to its task group.
>
> This looks good to me.
>
> Does anybody object to the -ENOSPC return value? Should we introduce
> -ENOTIME for that?

setuid() failed: No space left on device

For what it's worth, a message like that would be confusing to me if I
didn't already know the context. It's not a big problem in my opinion,
though; I'm just happy there's an error at all, now. :)

I just tested patch v6 and it works nicely for me. Again, thanks a bunch
for the attention to this issue.

-Corey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/