Re: ACPI hotplug panic with current git head

From: Jesse Barnes
Date: Wed Feb 18 2009 - 13:59:39 EST


On Monday, February 16, 2009 9:10 pm Kenji Kaneshige wrote:
> Jesse Barnes wrote:
> > On Wednesday, January 28, 2009 3:47 am Kenji Kaneshige wrote:
> >> I made several patches to fix the wrong assumption described
> >> above. It is very difficult for me to check all the code that
> >> refers pci_bus->self. So I checked include/linux/pci-acpi.h and
> >> the code under drivers/pci/ only. And I made patches for the code
> >> like below:
> >>
> >> - The code that clearly chooses host bridge operation or
> >> PCI-to-PCI bridge operation based on pci_bus->self.
> >>
> >> - The code that might cause endless loop if pci_bus->self is
> >> not NULL on the PCI root bus.
> >
> > Kenji-san, can you re-send these to my private mail so I can apply them?
> > (Outlook/Exchange can't let plain text through without molesting it for
> > some reason.)
> >
> > Thanks,
>
> Sure. Resending the following patches. I made those patches against
> 2.6.29-rc2. I've confirmed they can be applied to 2.6.29-rc5.
>
> - [PATCH 1/8] PCI/ACPI: fix wrong assumption in acpi_pci_get_bridge_handle
> - [PATCH 2/8] PCI/ACPI: fix wrong assumption in
> acpi_find_root_bridge_handle - [PATCH 3/8] PCI hotplug: fix wrong
> assumption in acpi_get_hp_params_from_firmware - [PATCH 4/8] PCI hotplug:
> fix wrong assumption in acpi_get_hp_hw_control_from_firmware - [PATCH 5/8]
> PCI: fix wrong assumption in pci_find_upstream_pcie_bridge - [PATCH 6/8]
> PCI: fix wrong assumption in pci_read_bridge_bases
> - [PATCH 7/8] PCI: fix wrong assumption in pci_get_interrupt_pin
> - [PATCH 8/8] PCI: fix wrong assumption in pci_common_swizzle

James have you tested this set? I didn't see your tested-by in the
changelogs... Just want to make sure if I'm going to send these to Linus for
2.6.29.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/