Re: [PATCH] hwmon/hdaps: remove redundant sysfs invert

[Jean Delvare]

On Thu, 19 Feb 2009 21:00:27 +0100, Frank Seidel wrote:
> Hi,
> 
> Jean Delvare wrote:
> > On Thu, 19 Feb 2009 13:44:43 +0100, Frank Seidel wrote:
> >> -	hdaps_invert = invert;
> >> -	hdaps_calibrate();
> > 
> > Apparently recalibration is necessary when you change the inversion
> > settings. The module parameter, which you made writable in a previous
> > patch, does _not_ recalibrate when changed.
> > 
> > So it was probably not such a good idea to make the module parameter
> > writable, and that should be reverted. Which in turn means that the
> > sysfs attribute "invert" has to stay.
> 
> Fully agree. I'll post a module-writeable revert patch tomorrow.

Don't bother, I've reverted this specific part myself already.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/