Re: [PATCH tj-percpu] percpu: s/size/bytes/g in new percpu allocatorand interface

[Tejun Heo]

Hello, Andrew.

Tejun Heo wrote:
> Do s/size/bytes/g as per Andrew Morton's suggestion.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> Okay, here's the patch.  I also merged it to #tj-percpu.  Having done
> the conversion, I'm not too thrilled tho.  size was consistently used
> to represent bytes and it's very customary especially if it's a memory
> allocator and I can't really see how s/size/bytes/g makes things
> better for percpu allocator.  Clear naming is good but not being able
> to use size in favor of bytes seems a bit extreme to me.  After all,
> it's size_t and sizeof() not bytes_t and bytesof().  That said, I have
> nothing against bytes either, so...

Eeeek... I'm sorry but I'm popping this patch.  It just doesn't look
right.  I'll add comments where appropriate that size is in bytes
instead.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/