Re: [PATCH B 06/10] OMAP3 pwrdm: add CORE SAR handling (for USBTLL module)

From: Russell King - ARM Linux
Date: Mon Feb 23 2009 - 09:38:26 EST


On Thu, Feb 05, 2009 at 08:52:17PM -0700, Paul Walmsley wrote:
> Hello Russell,
>
> On Sat, 31 Jan 2009, Russell King - ARM Linux wrote:
>
> > On Thu, Jan 29, 2009 at 02:15:44AM -0700, Paul Walmsley wrote:
> > > Hi Richard,
> > >
> > > On Thu, 29 Jan 2009, Paul Walmsley wrote:
> > >
> > > > > TLLSAR is not functional till ES3.1 (and beyound). Is it possible to flag it this way?
> > > >
> > > > Yes, it's easy in this case. Thanks for the note. I will send along an
> > > > updated patch for this.
> > >
> > > N.B. - fixxing this required a separate change to the omap_chip flag
> > > system, so I'll send the two necessary patches to the linux-omap mailing
> > > list for further testing.
> >
> > I'll hold off on this patch then.
>
> The patches that obsolete patch B 06 have lasted a week on linux-omap@vger
> without any comment, so am passing them along in subsequent E-mails.

It seems that the patches don't obsolete this patch, but instead
require this patch to be applied first.

We really really need to get out of this pattern of building fixes
on top of bad patches. If a patch is the wrong approach then it is
the wrong approach and should be dropped, or it should be merged with
the patches which fix stuff up to the new approach.

I'm going to combine B06 with patch 2 and hope things come out right.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/