Re: [PATCH] tracing/markers: make markers select tracepoints

From: Steven Rostedt
Date: Mon Feb 23 2009 - 12:31:46 EST



On Mon, 23 Feb 2009, Frank Ch. Eigler wrote:
>
> > Furthermore, trace_mark() exposes that crap like an ABI, now suppose
> > some distro goes and declares that stable for some daft reason,
> > imagine the poor sod having to fix something littered with
> > trace_mark().
>
> The impression that this is somehow different with tracepoints is
> mistaken. Tracepoints are *exactly* as "ABI-like" as markers.
>

I disagree with this point. markers are text strings that will eventually
appear to userspace. trace points need translation. A trace point can be
modified at any time and should never mess up user apps.

You may have a hook to a trace point that provides user apps a text based
output. If the trace point changes, this hook may break. But the tracer
maintainer of that hook will be responsible for that change, not the
maintainer of the code the tracepoint existed in.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/