Re: [PATCH 4/6] ftrace, x86: make kernel text writable only forconversions

From: Steven Rostedt
Date: Mon Feb 23 2009 - 13:24:17 EST



On Mon, 23 Feb 2009, Mathieu Desnoyers wrote:
>
> There is absolutely no link between stop_machine and text_poke. I argue
> against stop_machine saying that the breakpoint approach is less
> intrusive because it does not involve disabling interrupts for so long,
> and I argue against modifying the kernel page flags because that
> modifies the access rights of the core kernel and modules to RO

One correction. modules text is always mapped RW, event with
CONFIG_DEBUG_RODATA. Perhaps we could fix that, but as it is today,
you do not need text_poke to modify module text.

-- Steve

> mappings, which is IMO a side-effect that we should eliminate _if we
> can_. Please keep those two concerns separate.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/