Re: [PATCH 4/4] mqueue namespace: adapt sysctl

[Cedric Le Goater]

Alexey Dobriyan wrote:
> On Mon, Feb 23, 2009 at 09:09:33PM -0600, Serge E. Hallyn wrote:
>> +#ifdef CONFIG_PROC_FS
>> +static int proc_mq_dointvec(ctl_table *table, int write, struct file *filp,
>> +	void __user *buffer, size_t *lenp, loff_t *ppos)
>> +{
>> +	struct ctl_table mq_table;
>> +	memcpy(&mq_table, table, sizeof(mq_table));
>> +	mq_table.data = get_mq(table);
>> +
>> +	return proc_dointvec(&mq_table, write, filp, buffer, lenp, ppos);
>> +}
>> +
>> +static int proc_mq_dointvec_minmax(ctl_table *table, int write,
>> +	struct file *filp, void __user *buffer, size_t *lenp, loff_t *ppos)
>> +{
>> +	struct ctl_table mq_table;
>> +	memcpy(&mq_table, table, sizeof(mq_table));
>> +	mq_table.data = get_mq(table);
>> +
>> +	return proc_dointvec_minmax(&mq_table, write, filp, buffer,
>> +					lenp, ppos);
>> +}
>> +#else /* CONFIG_PROC_FS */
>> +static int proc_mq_dointvec(ctl_table *table, int write, struct file *filp,
>> +	void __user *buffer, size_t *lenp, loff_t *ppos)
>> +{
>> +	return -ENOSYS;
>> +}
>> +
>> +static int proc_mq_dointvec_minmax(ctl_table *table, int write,
>> +	struct file *filp, void __user *buffer, size_t *lenp, loff_t *ppos)
>> +{
>> +	return -ENOSYS;
>> +}
>> +#endif /* CONFIG_PROC_FS */
> 
> These should be under CONFIG_PROC_SYSCTL and one should define them to
> NULL otherwise.

ipc_sysctl.c and utsname_sysctl.c need to fix the CONFIG_PROC_FS #ifdef.

C.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/