Re: [PATCH] pcie_portdriver: FIX: pcie_port_device_remove (take 2)

[Eric W. Biederman]

Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> writes:

> On Friday, February 20, 2009 8:16:07 pm Eric W. Biederman wrote:
>> pcie_port_device_remove currently calls the remove method of port
>> drivers twice.  Ouch!
>>
>> We are calling device_for_each_child multiple times for no apparent
>> reason.
>>
>> So make it simple. Place put_device and device_unregister into
>> remove_iter, and throw out the rest.  Only call device_for_each_child
>> once.
>>
>> The code is simpler and actually works!
>>
>> Changelog:
>> v2 rebase against the linux-next tree so I don't conflict with Rafael's
>>    irq work, and remove the irq handling cleanups as Rafael's patch already
>>    made them.
>
> Thanks for rebasing; it's queued up in my linux-next branch now.  If we really 
> need this in the stable kernel it'll be a bit painful, since some of these 
> structures have changed around a bit...

I don't think it is necessary for stable.  The pciehp still needs more
work, and if anyone of the other port drivers was being hotplugged I
expect someone would have noticed the bug and fixed it before now.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/