Re: mmotm 2009-02-24-16-23 uploaded (proc_net & namespaces)

From: Serge E. Hallyn
Date: Wed Feb 25 2009 - 12:48:20 EST


Quoting Randy Dunlap (randy.dunlap@xxxxxxxxxx):
> Serge E. Hallyn wrote:
> > Quoting Randy Dunlap (randy.dunlap@xxxxxxxxxx):
> >> akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> >>> The mm-of-the-moment snapshot 2009-02-24-16-23 has been uploaded to
> >>>
> >>> http://userweb.kernel.org/~akpm/mmotm/
> >>>
> >>> and will soon be available at
> >>>
> >>> git://git.zen-sources.org/zen/mmotm.git
> >>>
> >>> It contains the following patches against 2.6.29-rc6:
> >> namespaces-move-proc_net_get_sb-to-a-generic-fs-superc-helper.patch,
> >> when CONFIG_NAMESPACES=n:
> >>
> >> proc_net.c:(.text+0x4255c): undefined reference to `get_sb_ns'
> >>
> >>
> >> config attached.
> >
> > Thanks, Randy. Does the following fix it?
> >
> > (Sorry, it's a misleading patch, and maybe it would turn out more
> > readable if I moved get_sb_ns under instead of above the
> > CONFIG_BLOCK ifdef... But all I'm doing is what the subject says,
> > plus adding an EXPORT_SYMBOL which may be debatable, but is in
> > keeping with other get_sb_*'s.)
>
> That causes problems in fs/super.c:
>
> fs/super.c: In function 'get_sb_ns':
> fs/super.c:773: error: 'ns_test_super' undeclared (first use in this function)

(!) I appended the wrong version.