Re: [PATCH core/percpu] percpu: fix too low alignment restrictionon UP

From: Ingo Molnar
Date: Wed Feb 25 2009 - 22:26:50 EST



* Tejun Heo <tj@xxxxxxxxxx> wrote:

> UP __alloc_percpu() triggered WARN_ON_ONCE() if the requested
> alignment is larger than that of unsigned long long, which is too
> small for all the cacheline aligned allocations. Bump it up to
> SMP_CACHE_BYTES which kmalloc allocations generally guarantee.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> ---
> Hello, Ingo.
>
> I somehow completely forgot about testing UP. Sorry about that. :-)
> The following patch should do it. Also available in the #tj-percpu
> tree.

Pulled into tip:core/percpu, thanks Tejun!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/