Re: [PATCH] perfcounters: fix a few minor cleanliness issues

From: Ingo Molnar
Date: Thu Feb 26 2009 - 07:04:35 EST



* Paul Mackerras <paulus@xxxxxxxxx> wrote:

> This fixes three issues noticed by Arnd Bergmann:
>
> - Add #ifdef __KERNEL__ and move some things around in perf_counter.h
> to make sure only the bits that userspace needs are exported to
> userspace.
>
> - Use __u64, __s64, __u32 types in the structs exported to userspace
> rather than u64, s64, u32.
>
> - Make the sys_perf_counter_open syscall available to the SPUs on
> Cell platforms.
>
> And one issue that I noticed in looking at the code again:
>
> - Wrap the perf_counter_open syscall with SYSCALL_DEFINE4 so we get
> the proper handling of int arguments on ppc64 (and some other 64-bit
> architectures).
>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx>
> ---
> This is in the master branch of my perfcounters.git tree at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/paulus/perfcounters.git master
>
> arch/powerpc/include/asm/systbl.h | 2 +-
> include/linux/perf_counter.h | 43 +++++++++++++++++++-----------------
> include/linux/syscalls.h | 9 ++-----
> kernel/perf_counter.c | 6 ++--
> 4 files changed, 30 insertions(+), 30 deletions(-)

Pulled into tip:perfcounters/core, thanks Paul!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/