Re: [git pull] DVB + ieee1394: firedtv driver

[Stefan Richter]

Ingo Molnar wrote:
> * Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Two choices that I can see:
> >
> >  - do the ieee1394_init() as a fs_initcall(), earlier
> >
> >  - move drivers/ieee1394 linking up to before drivers/media
> >
> > but I suspect that drivers/media wants to be early, in order to do the 
> > _media_ layer initialization early.

The former seems the better choice to me.  Changing the linking order 
would just break the next time around.

> > Does this work?
>
> yes, i just tested it and your patch fixes the crash:
>
>  mercury:~> uname -a
>  Linux mercury 2.6.29-rc6-tip-02011-gb62a1ed-dirty #250 SMP Thu 
>  Feb 26 19:00:54 CET 2009 i686 athlon i386 GNU/Linux
>  mercury:~> uptime
>   19:02:51 up 0 min,  1 user,  load average: 3.97, 1.10, 0.37
>
> Tested-by: Ingo Molnar <mingo@xxxxxxx>

Thanks guys.  I'm very sorry that this basic issue escaped my attention. 
It's the first time that a 1394 driver lives outside 
drivers/ieee1394/Makefile.

(Also shows that even very long exposure in linux-next does not catch 
runtime issues like this one.)

Stefan Richter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/