Re: [PATCH] mm: get_nid_for_pfn() returns int

[Andrew Morton]

On Fri, 27 Feb 2009 16:14:00 -0800
Gary Hade <garyhade@xxxxxxxxxx> wrote:

> On Fri, Feb 27, 2009 at 01:46:16PM -0800, Andrew Morton wrote:
>
> > > It is still lingering in -mm:
> > > http://userweb.kernel.org/~akpm/mmotm/broken-out/mm-get_nid_for_pfn-returns-int.patch
> > > 
> > 
> > Should it unlinger?  I have it in the 2.6.30 pile.
> 
> Yes, that would be good. :)

What would be good?  Your answer is ambiguous.

> > Does it actually fix a demonstrable bug?  
> 
> I am not aware of anyone that has actually reproduced the
> problem.

What problem?

All I gave at present is

  From: Roel Kluin <roel.kluin@xxxxxxxxx>

  get_nid_for_pfn() returns int

  Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
  Cc: Gary Hade <garyhade@xxxxxxxxxx>

>  I do not believe that we have any systems where 
> it can be reproduced since it would require both
>   (1) a memory section with an uninitialized range of
>       pages and
>   (2) a memory remove event for that memory section.
> As far as I know, none of our systems have (1).  Yasunori Goto
> has a system with (1) but I am not sure if he can do (2).

Please send a new changelog for this patch.

If you believe this patch should be merged into 2.6.29 then please
explain why.  Please also consider whether it should be backported into
2.6.28.x and eariler.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/