RE: hpsa: SCSI driver for HP Smart Array controllers

[Miller, Mike (OS Dev)]

crap 

> -----Original Message-----
> From: Stephen Cameron [mailto:smcameron@xxxxxxxxx] 
> Sent: Friday, February 27, 2009 8:59 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: scameron@xxxxxxxxxxxxxxxxxxxxxxx; Miller, Mike (OS Dev)
> Subject: Re: hpsa: SCSI driver for HP Smart Array controllers
> 
> 
> 
> I see we botched this in hpsa_pci_init() (one of the last 
> things we changed):
> 
> +       if (prod_index == ARRAY_SIZE(products)) {
> +               prod_index--;
> +               if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
> +                               !allow_unknown_smartarray) {
> +                       printk(KERN_WARNING "hpsa: Sorry, I don't "
> +                               "know how to access the Smart "
> +                               "Array controller %08lx\n",
> 
> 
> That 2nd if should have been, 
> 
> if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||
> 
> -- steve
> 
> 
>       
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/