Re: [PATCH mainline] menu: fix embedded menu snafu

[Ingo Molnar]

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 2 Mar 2009, Andrew Morton wrote:
> > 
> > This patch causes weird unintended breakage, methinks.
> 
> Damn, you're right. It looked obvious, so I already applied it, but I 
> clearly shouldn't have.
> 
> The whole "if EMBEDDED" thing is totally wrong, because those config 
> options  very much_do_ exist even when non-embedded, it's just that then 
> they always take their default valies.
> 
> Thanks for noticing.

probably also explains weird build breakages i've been getting 
since i updated to your latest:

  CC      kernel/futex.o
In file included from kernel/futex.c:61:
kernel/rtmutex_common.h: In function âtask_has_pi_waitersâ:
kernel/rtmutex_common.h:81: error: âstruct task_structâ has no 
member named âpi_waitersâ
kernel/rtmutex_common.h: In function âtask_top_pi_waiterâ:
kernel/rtmutex_common.h:87: error: âstruct task_structâ has no 
member named âpi_waitersâ
make[1]: *** [kernel/futex.o] Error 1

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/