Re: x86-tip: cpufreq breakage - bisectionfingers 89c9215165ca609096e845926d9a18f1306176a4

From: Mike Galbraith
Date: Wed Mar 04 2009 - 01:14:50 EST


On Wed, 2009-03-04 at 04:43 +0100, Mike Galbraith wrote:
> On Wed, 2009-03-04 at 10:59 +0900, Tejun Heo wrote:
>
> > I can't reproduce the problem here.
>
> Guess I'll have to sharpen a stick or two then.

With monkey-see-monkey-do-stick, box becomes happy camper again.

diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c
index c29f301..bc9972a 100644
--- a/arch/x86/kernel/setup_percpu.c
+++ b/arch/x86/kernel/setup_percpu.c
@@ -256,6 +256,11 @@ static struct page * __init pcpue_get_page(unsigned int cpu, int pageno)
+ ((size_t)pageno << PAGE_SHIFT));
}

+static void __init embed_populate_pte(unsigned long addr)
+{
+ populate_extra_pte(addr);
+}
+
static ssize_t __init setup_pcpu_embed(size_t static_size)
{
unsigned int cpu;
@@ -284,10 +289,15 @@ static ssize_t __init setup_pcpu_embed(size_t static_size)
pr_info("PERCPU: Embedded %zu pages at %p, static data %zu bytes\n",
pcpue_unit_size >> PAGE_SHIFT, pcpue_ptr, static_size);

+#if 0
return pcpu_setup_first_chunk(pcpue_get_page, static_size,
pcpue_unit_size,
pcpue_unit_size - static_size, pcpue_ptr,
NULL);
+#else
+ return pcpu_setup_first_chunk(pcpue_get_page, static_size,
+ 0, 0, NULL, embed_populate_pte);
+#endif
}

/*


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/