Re: [PATCH] fix DMI for EFI

From: Ingo Molnar
Date: Wed Mar 04 2009 - 06:00:49 EST



* Brian Maly <bmaly@xxxxxxxxxx> wrote:

> New patch. Its easier I think to just move efi_init() earlier. Seems
> less risky and less drawbacks.
>
> Signed-off-by: Brian Maly <bmaly@redhat>
>
>
> setup.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>

> --- a/arch/x86/kernel/setup.c 2009-03-03 21:24:53.000000000 -0500
> +++ b/arch/x86/kernel/setup.c 2009-03-03 21:26:00.000000000 -0500
> @@ -770,6 +770,9 @@ void __init setup_arch(char **cmdline_p)
>
> finish_e820_parsing();
>
> + if (efi_enabled)
> + efi_init();
> +
> dmi_scan_machine();

Hm, could we ever find ourselves in the positition of having to
access the DMI strings table in the EFI init code, to implement
a quirk? I think that's quite plausible.

OTOH, with some DMI quirks in EFI tables it's a bit of a chicken
and egg problem. Can DMI strings ever be outside of EFI tables
on EFI systems?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/