Re: [BUG] 2.6.29-rc* QinQ vlan trunking regression

From: David Miller
Date: Thu Mar 05 2009 - 02:45:54 EST


From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Thu, 05 Mar 2009 08:31:31 +0100

> Patrick McHardy wrote:
> > David Miller wrote:
> >> From: Patrick McHardy <kaber@xxxxxxxxx>
> >> Date: Thu, 05 Mar 2009 08:12:50 +0100
> >>
> >>>> We probably need both fixes to cover everything.
> >>>>
> >>> Yes, just the second one still crashes. I'm about to retry using both.
> >>
> >> Here is the updated version just for the record:
> >>
> >> vlan: Fix vlan-in-vlan crashes.
> > This still crashes. I'll have another look at the code.
>
> This one combined with your patch fixes the crash. The code was calling
> vlan_dev_neigh_setup recursively.
>
> Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
>
> (or Tested-by: in case you want to roll it into your patch).

Great work, thanks Patrick!

I'll get this all integrated and push it out to Linus.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/