Re: [PATCH] libata: add CFA specific identify data words

From: Bartlomiej Zolnierkiewicz
Date: Thu Mar 05 2009 - 11:20:18 EST


On Thursday 05 March 2009, Jeff Garzik wrote:
> From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
>
> Declare and use constants for CFA specific identify data words 162 and 163.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
> Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
>
> ---
> Sergei said:
> This patch is against the current pata-2.6 series. I'd prefer that Bart merged
> it thru his tree as my next patch adding CF mode support to IDE depends on it.
>
> jgarzik adds:
> I didn't see this in your latest submission, Bart. It is simple and

Simply because I haven't yet got to those patches + Sergei mentioned
that they need to be tested yet.

> harmless and might as well go ahead upstream, to eliminate the
> cross-tree dependency that Sergei speaks of (his patch also touched
> drivers/ata/libata-core.c, but I excluded that from below).

Fine with me if this makes things easier for everyone.

I updated git pull request with this patch fixing patch summary
(this is not libata specific change) and patch description (constants
are not currently unused) while at it.

From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Subject: [PATCH] ata: add CFA specific identify data words

Declare CFA specific identify data words 162 and 163 for future use.

Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
[bart: update patch summary/description]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
---
include/linux/ata.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

Index: linux-2.6/include/linux/ata.h
===================================================================
--- linux-2.6.orig/include/linux/ata.h
+++ linux-2.6/include/linux/ata.h
@@ -89,6 +89,8 @@ enum {
ATA_ID_DLF = 128,
ATA_ID_CSFO = 129,
ATA_ID_CFA_POWER = 160,
+ ATA_ID_CFA_KEY_MGMT = 162,
+ ATA_ID_CFA_MODES = 163,
ATA_ID_ROT_SPEED = 217,
ATA_ID_PIO4 = (1 << 1),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/