Re: [PATCH] mtd: plat_nand: add platform probe/remove callbacks

[Andrew Morton]

On Thu, 5 Mar 2009 18:58:12 -0500
"hartleys" <hartleys@xxxxxxxxxxxxxxxxxxx> wrote:

> From: "hartleys" <hartleys@xxxxxxxxxxxxxxxxxxx>

You might want to change your email setup so that the above reads "H
Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>" or whatever.  Because
most patch-merging people's tools will end up marking this commit as
being from someone called "hartleys".

Alternatively, put an explicit From: line at the top of the changelog.

> To: <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "Alexander Clouter" <alex@xxxxxxxxxxxxx>, "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, <vitalywool@xxxxxxxxx>
> Subject: [PATCH] mtd: plat_nand: add platform probe/remove callbacks
> Date: Thu, 5 Mar 2009 18:58:12 -0500
> 
> Add optional probe and remove callbacks to the plat_nand driver.
> 
> Some platforms may require additional setup, such as configuring
> the memory controller, before the nand device can be accessed.
> This patch provides an optional callback to handle this setup as
> well as a callback to teardown the setup.
> 
> This patch was originally submitted to linux-mtd but it was
> suggested I post it here for a broader review.

Looks OK to me, but I'm an MTD ignoramus.

> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Tested-By: Alexander Clouter <alex@xxxxxxxxxxxxx>
> 
> ---
> 
> diff --git a/drivers/mtd/nand/plat_nand.c b/drivers/mtd/nand/plat_nand.c
> index 75f9f48..600fbe9 100644

The patch was quite wordwrapped.  Please fix your email client for next
time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/