Re: [PATCH 2/2] ath5k: don't change mac in eeprom_read_mac on error

From: Bob Copeland
Date: Sat Mar 07 2009 - 07:35:19 EST


On Sat, Mar 07, 2009 at 10:26:42AM +0100, Jiri Slaby wrote:
> Do not touch mac parameter passed to ath5k_eeprom_read_mac unless
> we are sure we have correct address. I.e. when returning error, do
> not change it.
>
> While at it, use '= {}' compiler trick for memsetting mac_d.
>
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> Cc: Nick Kossifidis <jirislaby@xxxxxxxxx>

Wrong email address for Nick :) Otherwise,

Acked-by: Bob Copeland <me@xxxxxxxxxxxxxxx>

--
Bob Copeland %% www.bobcopeland.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/