Re: [Aufs 01/25] aufs documents

From: Sam Ravnborg
Date: Mon Mar 09 2009 - 01:47:01 EST


On Mon, Mar 09, 2009 at 12:24:54PM +0900, J. R. Okajima wrote:
> initial commit
> design and manual
>
> Signed-off-by: J. R. Okajima <hooanon05@xxxxxxxxxxx>
> ---

Documention seems impressive!
But your changelogs are in the contrary very sparse.

> fs/Kconfig | 1 +
> fs/Makefile | 1 +
The changes in the above files breaks bisectability.
You just broke "make oldconfig".


> fs/namei.c | 4 +-
> fs/splice.c | 10 +-
> include/linux/namei.h | 3 +
> include/linux/splice.h | 6 +
The changes to files outside fs/aufs2 needs to be justified in your changelog.
And they do not belong in this patch.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/