[PATCH] block: fix memory leak in bio_clone()

From: Li Zefan
Date: Mon Mar 09 2009 - 05:13:26 EST


If bio_integrity_clone() fails, bio_clone() returns NULL without freeing
the newly allocated bio.

Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
---
fs/bio.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/bio.c b/fs/bio.c
index 124b95c..896330e 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -465,8 +465,10 @@ struct bio *bio_clone(struct bio *bio, gfp_t gfp_mask)

ret = bio_integrity_clone(b, bio, fs_bio_set);

- if (ret < 0)
+ if (ret < 0) {
+ bio_put(bio);
return NULL;
+ }
}

return b;
-- 1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/