Re: [rtc-linux] [PATCH 7/7] powerpc/ps3: Add rtc-ps3

[Geert Uytterhoeven]

On Mon, 9 Mar 2009, Alessandro Zummo wrote:
> On Mon,  9 Mar 2009 14:26:23 +0100
> Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx> wrote:
> > +
> > +static int ps3_get_time(struct device *dev, struct rtc_time *tm)
> > +{
> > +	to_tm(read_rtc() + ps3_os_area_get_rtc_diff(), tm);
> > +	tm->tm_year -= 1900;
> > +	tm->tm_mon -= 1;
> > +	return 0;
> > +}
> 
>  this should be return rtc_valid_tm() .

Fixed.

>  can't you use functions from rtc-lib.c instead of 
>  that to_tm ?

Ah, those pesky PPC-specific functions... switched to rtc_time_to_tm() and
rtc_tm_to_time().

> > +
> > +MODULE_AUTHOR("Sony Corporation");
> 
>  real name, if possible and a contact address
>  here . Just in case I need someone to bother :)

All PS3-specific drivers have this. But there's an official PS3 platform
maintainer in MAINTAINERS.