Re: [PATCH] copy_process: fix CLONE_PARENT && parent_exec_idinteraction

[Oleg Nesterov]

On 03/09, David Howells wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > -	/* Our parent execution domain becomes current domain
> > -	   These must match for thread signalling to apply */
>
> Should you retain this comment somewhere?

This comment should be changed, but I failed to make the new one.
Actually, this was one of the reasons why the first patch I sent
http://marc.info/?l=linux-kernel&m=123602926516698
didn't touch the first ""p->parent_exec_id = ...".

There is a fat comment in exit_notify(), perhaps we can just add
/* see the comment in exit_notify() */.

But the "good" commenent should also explain that, since we re-use
->real_parent, the child also "inherits" the rights _and_ restrictions
to send ->exit_signal != SIGCHLD.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/