Re: [PATCH 1/7] tracing: typecast sizeof and offsetof to unsignedint

[Andrew Morton]

On Tue, 10 Mar 2009 00:57:11 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On x86_64 sizeof and offsetof are treated as long, where as on x86_32
> they are int. This patch typecasts them to unsigned int to avoid
> one arch giving warnings while the other does not.

Actually, both have type size_t.

>  static int trace_write_header(struct trace_seq *s)
>  {
> @@ -457,11 +458,11 @@ static int trace_write_header(struct trace_seq *s)
>  
>  	/* struct trace_entry */
>  	return trace_seq_printf(s,
> -				"\tfield:%s %s;\toffset:%lu;\tsize:%lu;\n"
> -				"\tfield:%s %s;\toffset:%lu;\tsize:%lu;\n"
> -				"\tfield:%s %s;\toffset:%lu;\tsize:%lu;\n"
> -				"\tfield:%s %s;\toffset:%lu;\tsize:%lu;\n"
> -				"\tfield:%s %s;\toffset:%lu;\tsize:%lu;\n"
> +				"\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
> +				"\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
> +				"\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
> +				"\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
> +				"\tfield:%s %s;\toffset:%u;\tsize:%u;\n"

Which may be printed with %z.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/