Re: [PATCH] Free setup_irq() interrupt V2

From: Ingo Molnar
Date: Tue Mar 10 2009 - 08:41:52 EST



* Magnus Damm <magnus.damm@xxxxxxxxx> wrote:

> From: Magnus Damm <damm@xxxxxxxxxx>
>
> This patch adds a __free_irq() function for releasing
> interrupts requested with setup_irq().
>
> Without this patch we have no way of releasing such
> interrupts since free_irq() today tries to kfree()
> the irqaction passed with setup_irq().
>
> Signed-off-by: Magnus Damm <damm@xxxxxxxxxx>
> ---
>
> Changes since V1:
> - break out a __free_irq() function, thanks Ingo!

Looks good. Could you please send it against the latest genirq
tree:

http://people.redhat.com/mingo/tip.git/README

as your patch does not apply cleanly anymore:

1 out of 3 hunks FAILED -- rejects in file kernel/irq/manage.c

> Why again are we not using struct list_head for the irqaction list?

irq_desc size mostly.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/