Re: [Xen-devel] Re: [PATCH] IRQ handling race and spurious IIR readin serial/8250.c

From: Alan Cox
Date: Thu Mar 12 2009 - 17:39:18 EST


> 1. It is definitely correct and does not introduce any new bugs.

Right ;)

> 2. It makes the existing bug definitely go away. That is, after my
> patch is applied the code drives the UART correctly - that is,
> according to the specification and in a manner guaranteed to be

The UART hardware and specifications diverge - often quite spectacularly.

> 4. Any fix which does not involve completely removing UART_BUG_TXEN
> will need my change.

Or the locking fix

It was described as a band aid so I treated it as such. Regardless of the
right thing to do long term its not a 2.6.29 candidate at this point but
certainly something that wants looking into in 2.6.30
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/