Re: [PATCH] dmaengine: sh: Add support DMA-Engine driver for DMA ofSuperH

[Nobuhiro Iwamatsu]

Hi, Matt.

Thank you for your review.

Matt Fleming wrote:
> On Thu, Mar 12, 2009 at 03:44:55PM +0900, Nobuhiro Iwamatsu wrote:
> > This supports DMA-Engine driver for DMA of SuperH.
> > This supported all DMA channels, and it was tested in SH7722/SH7780.
> > This can not use with SH DMA API and can control this in Kconfig.
>
> I was working on support for this, but fortunately for me you beat me
> to a finished implementation ;-)
>
> The code looks good to me. Just a few (very very) minor nits.
>
> Reviewed-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
>
> [...]
>
> > +/* for dma engine */
> > +/* mode */
> > +#define SHDMA_MIX_IRQ	(1 << 1)
>
> The proper multi-line kernel comment style is
>
> 	/*
> 	 *
> 	 */
>
> though this comment can all fit on one line.
OK, I fix it.
> > +
> > +static void dmae_init(struct sh_dmae_chan *sh_chan)
> > +{
> > +	u32 chcr = RS_DEFAULT; /* default is DUAL mode */
> > +	sh_dmae_writel(sh_chan, chcr, CHCR);
> > +}
> > +
> > +/*
> > + * Reset DMA controler
>
> controler -> controller
Oops, thank you.

I fix your check point and resend patch.

Best regards,
 Nobuhiro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/