Re: [PATCH, RFC] sysfs: only allow one scheduled removal callbackper kobj

[Alex Chiang]

* Cornelia Huck <cornelia.huck@xxxxxxxxxx>:
> On Thu, 12 Mar 2009 16:02:31 -0600,
> Alex Chiang <achiang@xxxxxx> wrote:
> > 
> > Cornelia, I understand your earlier point about a smaller patch
> > in the caller, but I think pushing the code down into the
> > infrastructure is the right thing to do. 
> 
> OK, I don't have further objections.

Thanks.

> > Also, I wasn't brave
> > enough to patch your ccwgroup_ungroup_store(), but I think you
> > won't need the gdev->onoff stuff anymore in that code path.
> 
> We still need it to prevent online/offline vs. ungroup races.
> 
> While device_schedule_callback() should not be able to return -EAGAIN
> on us, I'll sleep better if you could add the following snippet to your
> patch:

Added and resent to Greg.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/