Re: [PATCH V3] kallsyms, tracing: output more proper symbol name

[Sam Ravnborg]

On Fri, Mar 13, 2009 at 05:27:32PM +0800, Lai Jiangshan wrote:
> Lai Jiangshan wrote:
> > Paulo Marques wrote:
> >> I would probably still place another test to compare the number of
> >> underscores, after both symbols are found to be equal in the "linker
> >> script provided" criteria.
> >>
> >> The way it is now, for my current kallsyms table:
> >>
> >>> ffffffff80200000 A _text
> >>> ffffffff80200000 T startup_64
> >>> ffffffff80209000 T _stext
> >>> ffffffff80209000 t init_post
> >> a "startup_64" address would display as "_text" and a "init_post"
> >> address would display as "_stext".
> >>
> >> You can add all the stext/etext symbols as special cases to the
> >> "may_be_linker_script_provide_symbol" function (like it was on your v1
> >> patch), but I'm just afraid that we'll find more cases in the future
> >> that are not automatically caught by these rules...
> >>
> > 
> 
> [resend, previous v3 has some mistakes]
> 
> Subject:  kallsyms, tracing: output more proper symbol name
> 
> Impact: bugfix, output reliable result
> 
> Debug tools(dump_stack(), ftrace...) are like to print out symbols.
> But it is always print out the first aliased symbol.(Aliased symbols
> are symbols with the same address), and the first aliased symbol is
> sometime not proper.
> 
> # echo function_graph > current_tracer
> # cat trace
> ......
>  1)   1.923 us    |    select_nohz_load_balancer();
>  1) + 76.692 us   |  }
>  1)               |  default_idle() {
>  1)   ==========> |    __irqentry_text_start() {
>  1)   0.000 us    |      native_apic_mem_write();
>  1)               |      irq_enter() {
>  1)   0.000 us    |        idle_cpu();
>  1)               |        tick_check_idle() {
>  1)   0.000 us    |          tick_check_oneshot_broadcast();
>  1)               |          tick_nohz_stop_idle() {
> ......
> 
> It's very embarrassing, it ouputs "__irqentry_text_start()",
> actually, it should output "smp_apic_timer_interrupt()".
> (these two symbol are the same address, but "__irqentry_text_start"
> is deemed to the first aliased symbol by scripts/kallsyms)
> 
> This patch puts symbols like "__irqentry_text_start" to the second
> aliased symbols. And a more proper symbol name becomes the first.
> 
> Aliased symbols mostly come from linker script. The solution is
> guessing "is this symbol defined in linker script", the symbols
> defined in linker script will not become the first aliased symbol.
> 
> And if symbols are found to be equal in this "linker script provided"
> criteria, symbols are sorted by the number of prefix underscores.
> 
> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>

Looks good to me.

Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/