Re: [Xen-devel] [PATCH 10/27] xen: make sure swiotlb allocation isphysically contigious

From: Jan Beulich
Date: Mon Mar 16 2009 - 09:29:49 EST


>>> Jeremy Fitzhardinge <jeremy@xxxxxxxx> 13.03.09 17:59 >>>
> void * __init swiotlb_alloc_boot(size_t size, unsigned long nslabs)
> {
>- return alloc_bootmem_low_pages(size);
>+ void *ret = alloc_bootmem_low_pages(size);
>+
>+ if (ret && xen_pv_domain())
>+ xen_swiotlb_fixup(ret, size, nslabs);
>+
>+ return ret;
> }

While on native using alloc_bootmem_low_pages() is a requirement here,
on Xen this should explicitly not be used, as we realized just a couple of
days ago: The way the bootmem allocator works, running out of space
below 4Gb is pretty easy on machines with lots of memory, and since the
swiotlb is a requirement for Dom0, the risk of allocation failures must be
kept as low as possible.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/