Re: [PATCH] Block - Honour barrier requests in loop driver

From: Christoph Hellwig
Date: Tue Mar 17 2009 - 15:09:35 EST


On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote:
> + if (!file->f_op || !file->f_op->fsync) {
> + ret = -EOPNOTSUPP;
> + goto out;
> + }

file->f_op is never zero, so you can remove the checks for that.
Otherwise looks good.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/