Re: [PATCH 1/2 -tip] sched: Clean unused fields from struct rq

From: Luis Henriques
Date: Wed Mar 18 2009 - 16:10:53 EST


On Tue, Mar 17, 2009 at 09:33:19PM -0400, Gregory Haskins wrote:
> >> I think this bit is ABI, so you either have to bump the version number
> >> or emit 0s, iirc gregory touched some of that last -- or at least wrote
> >> userspace for it..
> >>
> >
> > Hmm... you're right. I should have though about that. Anyway, what is the
> > the best approach here?
> >
> > I know that changes in ABI shall not break anything, but just increasing the
> > version number will really solve the issue? Will userspace care for this?
> > On the other hand, just writting 0s does not sound interesting either...
> >
> >
> Hi Luis,
> My app does check the version number, so bumping it is probably the
> best solution. Be sure to keep me in the loop about whether this patch
> gets merged and I will be sure to update it to handle the new version.

Hi Greg,

(sorry for the _huge_ delay for replying, but my timeslice for lkml is quite
small...)

I'll quickly prepare another patch that also modifies the version and repost it.
Maybe you can then give me more feedback on it.

Thanks for comments.
--
Luis Henriques
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/