Re: [PATCH -tip] sched: Clean unused fields from struct rq

From: Luis Henriques
Date: Wed Mar 18 2009 - 17:59:13 EST


Hi,
On Wed, Mar 18, 2009 at 05:00:06PM -0400, Gregory Haskins wrote:
> I actually key off the SCHEDSTAT_VERSION (currently 14) at the top of
> kernel/sched_stats.h. Cursory inspection of the existing code and your
> patch says that this should actually be the value that needs updating
> (vs. vSched-Debug). However, note that I am not sure if there are also
> users of sched-debug that need to see that version bump as well in order
> to remain compatible.

Just realised something while taking a look at you're schedtop: you are
referring to sched_stats, which shows data in /proc/schedstat, while my patch
actually targets sched_debug, which shows data in /proc/sched_debug. And I
guess this is why we have 2 different versioning mechanisms: they refer to
different things :-)

So, if this is correct, my last patch actually updates the correct version,
right?

Regards,
--
Luis Henriques
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/