Re: [patch] x86, bts: use atomic memory allocation

From: Ingo Molnar
Date: Fri Mar 20 2009 - 14:56:29 EST



* Metzger, Markus T <markus.t.metzger@xxxxxxxxx> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@xxxxxxx]
> >Sent: Thursday, March 19, 2009 5:12 PM
> >To: Metzger, Markus T
>
>
> >> Ds_request_bts() needs to allocate memory. It uses GFP_KERNEL.
> >>
> >> Hw-branch-tracer calls ds_request_bts() within on_each_cpu().
> >>
> >> Use atomic memory allocation to allow it to be used in that context.
> >
> >the hw-branch-tracer still crashes during bootup. Have you tried the
> >config i sent to you, and have you tried to reproduce it? I've
> >attached another config that crashes.
>
> The first config boots OK.

> The second config boots OK with the additional changes to keep the
> GFP_KERNEL and move the ds_request_bts() calls out of the
> on_each_cpu() in the hw-branch-tracer.
>
> I don't know yet what exactly causes the crash and if there is a
> simpler fix.

hm, this was an AMD box - so perhaps they dont have a compatible DS
implementation?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/