Re: [PATCH] trace/ring_buffer: fix section mismatch warning

From: Ingo Molnar
Date: Sat Mar 21 2009 - 10:39:38 EST



* Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:

> From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> With linux-next I get this:
>
> Section mismatch in reference from the function
> ring_buffer_alloc() to the function .cpuinit.text:rb_cpu_notify()
> The function ring_buffer_alloc() references the function __cpuinit
> rb_cpu_notify(). This is often because ring_buffer_alloc lacks a
> __cpuinit annotation or the annotation of rb_cpu_notify is wrong.
>
> This is a false positive since rb_cpu_notify gets only referenced
> if CONFIG_HOTPLUG_CPU=y. To get rid of the warning annotate
> ring_buffer_alloc with __ref.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> ---
> kernel/trace/ring_buffer.c | 2 +-

Frederic has beaten you to it narrowly:

09c9e84: tracing/ring-buffer: don't annotate rb_cpu_notify with __cpuinit

:)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/