Re: [PATCH v2] perfcounters: record time running and time enabledfor each counter

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > +	u64				time_enabled;
> > +	u64				time_running;
> 
> These look like times.  I see no indication (here) as to the units.
> 
> > +	u64				start_enabled;
> 
> This looks like a boolean, but it's u64.
> 
> > +	u64				start_running;
> 
> hard to say.
> 
> > +	u64				last_stopped;
> 
> probably a time, unknown units.
> 
> 
> Perhaps one of the reasons why this code is confusing is the 
> blurring between the "time" at which an event occured and the 
> "time" between the occurrence of two events.  A weakness in 
> English, I guess.  Using the term "interval" in the latter case 
> will help a lot.

What we use in the scheduler is "sum_time" or "runtime". A bit of a 
tongue twister but unambiguous.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/