Re: linux-next: Tree for March 23 (media/video/hdpvr)

From: Janne Grunau
Date: Mon Mar 23 2009 - 17:20:24 EST


On Mon, Mar 23, 2009 at 10:04:15PM +0100, Hans Verkuil wrote:
> On Monday 23 March 2009 21:49:40 Janne Grunau wrote:
> >
> > diff --git a/drivers/media/video/hdpvr/hdpvr-core.c
> > b/drivers/media/video/hdpvr/hdpvr-core.c index e7300b5..dadb2e7 100644
> > --- a/drivers/media/video/hdpvr/hdpvr-core.c
> > +++ b/drivers/media/video/hdpvr/hdpvr-core.c
> > @@ -21,6 +21,7 @@
> > #include <linux/usb.h>
> > #include <linux/mutex.h>
> > #include <linux/i2c.h>
> > +#include <linux/autoconf.h>
> >
> > #include <linux/videodev2.h>
> > #include <media/v4l2-dev.h>
>
> Don't include autoconf.h! It's preloaded for you already and shouldn't be
> included manually. Esp. since the v4l-dvb tree creates and preloads a custom
> version. Loading it manually will overwrite that.
>
> Other than that it's fine.

Thanks Hans,

fixed in the patch sent to Mauro.

Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/