[tip:tracing/filters] tracing/filters: free pred when clearing filters

From: Tom Zanussi
Date: Tue Mar 24 2009 - 03:29:06 EST


Commit-ID: 09f1f245c79585383de63e3ca54d0f91824bff3a
Gitweb: http://git.kernel.org/tip/09f1f245c79585383de63e3ca54d0f91824bff3a
Author: Tom Zanussi <tzanussi@xxxxxxxxx>
AuthorDate: Tue, 24 Mar 2009 02:14:11 -0500
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Tue, 24 Mar 2009 08:26:51 +0100

tracing/filters: free pred when clearing filters

Impact: fix (small) per trace filter modification memory leak

Free the current pred when clearing the filters via the filter files.

Signed-off-by: Tom Zanussi <tzanussi@xxxxxxxxx>
Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
Cc: =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@xxxxxxxxx>
LKML-Reference: <1237878851.8339.58.camel@charm-linux>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>


---
kernel/trace/trace_events.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index fdab30d..a938138 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -516,6 +516,7 @@ event_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,

if (pred->clear) {
filter_free_preds(call);
+ filter_free_pred(pred);
return cnt;
}

@@ -581,6 +582,7 @@ subsystem_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,

if (pred->clear) {
filter_free_subsystem_preds(system);
+ filter_free_pred(pred);
return cnt;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/