Re: [PATCH 07/13] [usb] changed ioctls to unlocked

From: Alan Cox
Date: Tue Mar 24 2009 - 18:20:40 EST


On Tue, 24 Mar 2009 15:09:53 -0700
Greg KH <greg@xxxxxxxxx> wrote:

> On Tue, Mar 24, 2009 at 04:12:42PM -0500, stoyboyker@xxxxxxxxx wrote:
> > From: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> >
> > Signed-off-by: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> > ---
> > drivers/usb/mon/mon_bin.c | 53 ++++++++++++++++++++++++++++++++------------
> > 1 files changed, 38 insertions(+), 15 deletions(-)
>
> NAK, you're just pushing lock_kernel() down for no good reason.

Actually the underlying reason is to get rid of the old ->ioctl hook
entirely so it makes sense to do this but yes for simple drivers they
just want fixing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/